[LookingMan]

Seems taglib (or not taglib) problem appeared again.
I'm talking about the bug http://getsatisfaction.com/songbird/topi..._non_ascii which has been closed.

Steps to reproduce:
Just install MLyrics, try to edit the lyrics with something like: Это проверка
Save (for save to complete you may need to pause playback). Now remove the track with saved lyrics from the library. Import the track again and you will see the lyrics was saved as ??? ????????

Found a temporary solution: replace sbMetadataHandlerTaglib.so in components directory with Songbird's (Tested with Songbird 2.1.0a, Build 2297 (20120526014106))

[LookingMan]

Just re-downloaded http://sourceforge.net/projects/ngale/fi...2/download and unfortunately the bug exist there too.

Found a temporary solution: replace sbMetadataHandlerTaglib.so in components directory with Songbird's (Tested with Songbird 2.1.0a, Build 2297 (20120526014106))

P.S: So the problem in the taglib.

---

If you look deeper at
http://bugzilla.songbirdnest.com/show_bug.cgi?id=22958
there was a patch
http://bugzilla.songbirdnest.com/attachm...ction=diff
which is applied to SB's taglib
http://src.songbirdnest.com/xref/vendor/...sframe.cpp
but not applied to NG's taglib
https://github.com/nightingale-media-pla...sframe.cpp
(I'm assuming NG uses this taglib)

So why NG doesn't use SB's taglib?

P.S: I cannot build NG now, so asking for someone to try the patch.
P.P.S: Saved lyrics in mp3 can also easily be viewed with eyeD3 program.

---

Opened an issue https://github.com/nightingale-media-pla...issues/115

[rsjtdrjgfuzkfg]

I'm on vacation right now and thus without a building environment. Note that at least on windows there are tons of issues with taglib we need to dive into, probably reimplement the wrapper from scratch so we do not rely on Songbird's patches there and can use system taglib on linux and build more easy on windows. There are many related issues on github, feel free to add yours

[LookingMan]

OK, the issue was opened. But could we temporary use SB's taglib (or temporary apply patch after you come back)? Because this bug is really ugly. I found temporary solution, but other people may not see this thread and discover the bug after system or NG complete reinstall (and tons of lyrics will be corrupted ).

P.S: This bug is freaking me out.

[ilikenwf]

Yeah - you can build against the SB taglib.

I'll rebuild the deps when we launch 1.11.1 - we need a few more bugfixes before we mark that milestone, though.

[LookingMan]

OK, thanks.

[rsjtdrjgfuzkfg]

(07-24-2012, 03:48 AM)LookingMan Wrote: But could we temporary use SB's taglib (or temporary apply patch after you come back)?

...on Windows we use SB's taglib currently. Doesn't it work there?

[LookingMan]

Don't know, NG crashes there every time I try to erase lyrics or set new, and then fails to correctly read track metadata (artist and album empty, track name set to mp3's name). Should I open an issue on that too?

[rsjtdrjgfuzkfg]

(07-25-2012, 10:52 PM)LookingMan Wrote: Don't know, NG crashes there every time I try to erase lyrics or set new, and then fails to correctly read track metadata (artist and album empty, track name set to mp3's name). Should I open an issue on that too?

No, that's known (issue #65 or something if I remember right). That's the reason we need to get away from the SB-patched taglib. Somehow our build and their deps don't go along that well on Windows...

[ilikenwf]

Aside from the fact that using a custom patched taglib is retarded.