[eagebhart]

I have found that it is impossible to edit the track title. No matter what it always
reverts to the filename of the track. I have tried changing the name in
several different ways. I sometimes see it change, then change back.

I am running on OS X with this version.
Version: Nightingale 1.12.1, Build 2453 (20130921033204)

[rsjtdrjgfuzkfg]

(10-19-2013, 07:13 AM)eagebhart Wrote: I have found that it is impossible to edit the track title. No matter what it always
reverts to the filename of the track.

Does this happen on all media items? What media type (flac, mp3,...)? Do you see messages in the error console (Tools menu)?

[eagebhart]

(10-19-2013, 12:08 PM)rsjtdrjgfuzkfg Wrote:

(10-19-2013, 07:13 AM)eagebhart Wrote: I have found that it is impossible to edit the track title. No matter what it always
reverts to the filename of the track.

Does this happen on all media items? What media type (flac, mp3,...)? Do you see messages in the error console (Tools menu)?

I was editing flac files. I'll have to do some dedicated testing to try mp3's. I keep all my music in flac.

No errors. I noticed it first through the extension I've been working on.

It has been working fine on songbird. The javascript is pretty tight, so trackName isn't treated any different than any other field, it's all the same code regardless of name.

I was batch editing an album with csv data, trackname, album, artist, year, comment, and genre were all being updated. The edit worked, and the update progress bar did it's thing.

I then tried the same extension with just an update to trackName. Then the same with just one track. Thats when I started noticing it blink.

Then I tried editing trackName with my other tag editing plugin which has been working for over a year. I don't know that I ever noticed song names not changing in nightingale.

Then I tried editing directly in the tree field. Finally I tried editing in the view metadata field. It was the same in every case.

The only thing I could see was the new value would populate the tree view momentarily and then it would get over written with the old value.

It was fairly easy to see because I was removing the (featuring <somesinger>) on the end of the track name.

[freaktechnik]

So is it not correctly overwriting the actual tag in the file or is it just faulty in the database of Nightingale?

[eagebhart]

I'm running some tests this morning to see what I can figure out.

---

I tried the same tests with mp3, mp4 and flac files.

Here's the basics, see below for more details.

1. It's not related to the filename.
2. mp3 works fine.
3. mp4 works fine.
4. flac will change momentarily and then write the old value back.
5. the value is not changed in the database or the flac file.
6. This is not limited to trackName/Title other fields do not change either.
7. Oddity. - Comment was blank, I added something it stayed. I removed it, it stayed clear. It did not change the flac file.

I started by renaming a flac file. So the metadata title for this song was still 'La Mariposa'.
The filename was set to 'La Mariposa (feat. flac)'
I imported it into Nightingale.
I started by editing directly in the tree view and watched it change back.
I also tried editing in the metadata view dialog.

I did the same with the album name, genre, artist, and album artist. All behave the same. Comment was empty and
appears to work but never updates the flac file. There were no errors displayed.

Metaflac from the command line shows that nothing has changed in the file.

┌─(eric@Stratus)────────────────────(~/music/testflac/Osvaldo Fresedo/Serie de oro)─┐
└─(12:04:%)── metaflac --export-tags-to=- 02\ La\ mariposa\ \(feat.\ flac\).flac ──#(Sat,Oct19)─┘
ALBUM=Serie de oro
ALBUMARTIST=Osvaldo Fresedo
DATE=2002
ENCODER=X Lossless Decoder 20121222
GENRE=Tango
TITLE=La mariposa
TOTALTRACKS=14
TRACKNUMBER=2
TRACKTOTAL=14


I cleared the error log before trying a single edit in the tree field.
The error log shows a few things. These look related...

Warning: reference to undefined property SBProperties.composer
Source File: chrome://tangoinfo/content/tangoinfo.js
Line: 221

Error: keyelement.setTarget is not a function
Source File: chrome://songbird/content/bindings/dynKeyset.xml
Line: 118

This doesn't look particularly related, but it was in there.

Error: [Exception... "Could not convert JavaScript argument arg 0 [sbIAlbumArtListener.onSearchComplete]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location: "JS frame :: file:///Users/eric/Library/Application%20Support/Nightingale/Profiles/azyfwy4h.default/extensions/Songbird.TrackArtFetcher@gmail.com/components/sbTrackAlbumArtFetcher.js :: anonymous :: line 270" data: no]
Source File: file:///Users/eric/Library/Application%20Support/Nightingale/Profiles/azyfwy4h.default/extensions/Songbird.TrackArtFetcher@gmail.com/components/sbTrackAlbumArtFetcher.js
Line: 270

[eagebhart]

Here's the title change showing in the mp4 file I used. The title and the filename match after the title edit in Nightingale.

atomicparsley 01\ Yo\ llevo\ un\ tango\ en\ el\ alma\ \(feat.\ mp4\).m4a -t ──#(Sat,Oct19)─┘

Atom "----" [com.apple.iTunes;MusicBrainz Album Artist Id] contains: c67f5072-35db-46a0-b7be-de46f31c8eac
Atom "----" [com.apple.iTunes;MusicBrainz Album Id] contains: 460ad324-6be9-40b6-844c-d70348b3a17c
Atom "----" [com.apple.iTunes;MusicBrainz Artist Id] contains: c67f5072-35db-46a0-b7be-de46f31c8eac
Atom "----" [com.apple.iTunes;MusicBrainz Disc Id] contains: A3eKUFIuC1ayChLHYyeUlr0o608-
Atom "----" [com.apple.iTunes;MusicBrainz Track Id] contains: bce717d7-3efe-43c6-8852-d8aead6b2334
Atom "----" [com.apple.iTunes;iTunes_CDDB_1] contains: 360E4214+273962+20+150+14297+27820+41960+51645+65504+79793+92486+105698+118924+131843+145850+157654+172434+187980+202074+217175+230866+246230+259346
Atom "----" [com.apple.iTunes;iTunes_CDDB_TrackNumber] contains: 1
Atom "aART" contains: Alberto Castillo
Atom "disk" contains: 1 of 1
Atom "trkn" contains: 1
Atom "©ART" contains:
Atom "©alb" contains: Sus primeros éxitos, Vol. 1 (Reliquias 1999)
Atom "©cmt" contains:
Atom "©day" contains: 0
Atom "©gen" contains: Tango
Atom "©nam" contains: Yo llevo un tango en el alma (feat. mp4)
Atom "©too" contains: X Lossless Decoder 20121222, QuickTime 7.7.1
Atom "covr" contains: 1 piece of artwork

[eagebhart]

actually, this error was mine. I fixed it already.

Warning: reference to undefined property SBProperties.composer
Source File: chrome://tangoinfo/content/tangoinfo.js
Line: 221

[rsjtdrjgfuzkfg]

As you're trying to buid anyways, you should be able to attach a debugger on debug builds (no idea of how to do that on macs... but there should be a way). If you get that working, maybe you could check if the metadata changing stuff is properly executed? I could probably find you the references for the tag writing quite fast, probably not so fast for the library writing, feel free to contact me if you need help locating that, I read through parts of the whole metadata stuff some time ago when updating taglib.

[eagebhart]

yea, I figured once I get the build going that would be the first thing to look at. This is what is keeping me from using Nightingale fulltime. Album art would be a nice addition. And there is that branch that hasn't been integrated yet. So that could help point me in the right places too. I'll ping you when I get to that point, it would be nice to narrow my hunting.

Building is going ok. As building does. A bit of a pain sorting through stuff. I'm keeping notes in evernote.

The idea of macs being so different is funny to me. OS X is not all that different from linux or freebsd. It has it's own pains, xcode and old libraries, a real PIA. But mostly it's the same. I use vim and gdb for most of what I do. And it all works the same way. All three of those OS's have more in common than not and are all drastically different from windows.

That said, I have no idea what platforms most of you are on, but I'm guessing it's not windows.

[rsjtdrjgfuzkfg]

(10-22-2013, 10:52 AM)eagebhart Wrote: That said, I have no idea what platforms most of you are on, but I'm guessing it's not windows.

I'm currently on windows... and I cannot think of mac being that similar to linux tbh, as Apple always tries to violate existing standards and create own ones (as that causes their customers to be locked into the apple infrastructure, resulting in more profit).

However, all can run code and it is possible to use the same codebase for all platforms (besides some platform-specific additions), and most tools are cross-platform; so I agree that there is a large chunk of similarity as well. I personally use most linux shell tools in windows right now, as I prefer the linux shell...

The main issue is that a the term "stable" is quite dependent on the OS... changes may not work on another OS (or worse, break it) without the dev doing the change having a chance to detect it.