[Manko10]

Same here on Gentoo x86_64 (AMD64). Complete make dump http://pastebin.com/47CEMEZd
Other question: would Nightingale build against Xulrunner 2.0?

[pythonian4000]

(03-11-2011, 01:11 AM)Manko10 Wrote: Same here on Gentoo x86_64 (AMD64). Complete make dump http://pastebin.com/47CEMEZd
Other question: would Nightingale build against Xulrunner 2.0?

No idea about what is causing that sorry. stevo has been able to get both to compile FWIR so hey can probably help.

Other answer: not without a LOT of work. Songbird only just upgraded to Xulrunner 1.9.2 over the course of version 1.9, and I doubt we can easily leapfrog them ^_^

[Manko10]

So Songbird will not be able to build against my system Xulrunner, what a pity. If it could, build times would be reduced dramatically.

[pythonian4000]

(03-11-2011, 06:03 AM)Manko10 Wrote: So Songbird will not be able to build against my system Xulrunner, what a pity. If it could, build times would be reduced dramatically.

There is no chance of building against ANY system Xulrunner at present, because Songbird uses a version with custom patches. Some of these patches have made it upstream but there are many that haven't, and getting them upstream isn't a major priority for POTI. But I'm sure that they would be happy to help us work through them at some point, and hopefully we can get them all upstream, or else work out why they are needed and try and circumvent the issue in Nightingale (though I see this failing, as if it could have been fixed in Songbird then there likely wouldn't be a patch to Xulrunner).

[Manko10]

However, I think Xulrunner 2.0 would be a great improvement as it's much faster. Add-ons like the cover flow are really slow with halting animations if you have more than just five or ten albums.

[Rowen]

I'm on Ubuntu 11.04 x86 (aka 32 bit) and when I run " make -f nightingale.mk [debug|release] "
I get the message

Code:

install: missing destination file operand after `/home/rowen/Documents/ngale/compiled-debug-i686/dist/gst-plugins/libgstcoreelements.so'
Try `install --help' for more information.
make[4]: *** [/home/rowen/Documents/ngale/compiled-debug-i686/dist/gst-plugins/libgstcoreelements.so] Error 1
make[4]: Leaving directory `/home/rowen/Documents/ngale/compiled-debug-i686/dependencies'
make[3]: *** [libs_tier_deps] Error 2
make[3]: Leaving directory `/home/rowen/Documents/ngale/compiled-debug-i686'
make[2]: *** [tier_deps] Error 2
make[2]: Leaving directory `/home/rowen/Documents/ngale/compiled-debug-i686'
make[1]: *** [default] Error 2
make[1]: Leaving directory `/home/rowen/Documents/ngale/compiled-debug-i686'
make: *** [build] Error 2

There is no trunk file as I made the initial ngale file in RapidSVN first but this should not be the issue because it is basically the trunk folder with a diffrent name

[Scriptor]

I'm on arch x86_64 and can't build too

[stevo]

I apologize for all the build issues we are having, I am working on fixing that up as quickly as I can.

[Scriptor]

(03-25-2011, 01:41 AM)stevo Wrote: I apologize for all the build issues we are having, I am working on fixing that up as quickly as I can.

No problem, despite the build issues, you're making a great job, so keep it up ;)

[Leonidas]

Very good job
I'm experiencing the same issues about implicit and regular rules.
My system is running Fedora 14.

EDIT: IT'S WORKING NOW! Read on to see my fixes

Code:

$ make -f nightingale.mk
Adding configure options from /home/leonidas/Desktop/ngale/nightingale.config:
  --enable-debug
  --enable-tests
Nightingale Build System
mkdir -p /home/leonidas/Desktop/ngale/compiled-debug-`arch` /home/leonidas/Desktop/ngale/compiled-debug-`arch`/dist
mkdir -p /home/leonidas/Desktop/ngale/compiled-debug-`arch` /home/leonidas/Desktop/ngale/compiled-debug-`arch`/dist
cd /home/leonidas/Desktop/ngale/compiled-debug-`arch` && \
   /home/leonidas/Desktop/ngale/configure --enable-debug --enable-tests  --enable-tests
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking for gcc... gcc
checking whether we are using the GNU C compiler... no
checking whether gcc accepts -g... no
checking for gcc option to accept ISO C89... unsupported
checking for g++... g++
checking whether we are using the GNU C++ compiler... no
checking whether g++ accepts -g... no
checking for gawk... gawk
checking for chmod... chmod
checking for gnucp... no
checking for gcp... no
checking for cp... cp
checking for gdiff... no
checking for diff... diff
checking for doxygen... doxygen
checking for ggrep... no
checking for grep... grep
checking for gzip... gzip
checking for gunzip... gunzip
checking for find... find
checking for install... install
checking for ln... ln
checking for packagemaker... no
checking for gmd5sum... no
checking for md5sum... md5sum
checking for mkdir... mkdir
checking for mv... mv
checking for perl... perl
checking for python... python
checking for rm... rm
checking for gsha1sum... no
checking for sha1sum... sha1sum
checking for sort... sort
checking for gtar... gtar
checking for touch... touch
checking for unzip... unzip
checking for zip... zip
checking for g++... g++
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking for library containing pthread_create... -lpthread
checking for pkg-config... /usr/bin/pkg-config
checking for gtk+-2.0... yes
checking GTK_CFLAGS... -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12  
checking GTK_LIBS...   -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lm -lcairo -lpng12 -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0  
checking for glib-2.0... yes
checking GLIB_CFLAGS... -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  
checking GLIB_LIBS...   -lglib-2.0  
checking for dbus-glib-1... yes
checking DBUS_CFLAGS... -pthread -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  
checking DBUS_LIBS... -L/lib64   -ldbus-glib-1 -ldbus-1 -lpthread -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0  
checking for hal... yes
checking HAL_CFLAGS... -DDBUS_API_SUBJECT_TO_CHANGE -I/usr/include/hal -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include  
checking HAL_LIBS... -L/lib64   -lhal -ldbus-1 -lpthread -lrt  
checking for gstreamer-0.10 >= 0.10.1 gstreamer-plugins-base-0.10 >= 0.10.7... yes
checking GSTREAMER_CFLAGS... -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libxml2  
checking GSTREAMER_LIBS...   -lgstreamer-0.10 -lgobject-2.0 -lgmodule-2.0 -lxml2 -lgthread-2.0 -lrt -lglib-2.0  
checking for PR_Cleanup in -lnspr4... no
checking for _XRE_Main in -lxul... no
allmakefiles.sh: finding makefiles...
~/Desktop/ngale ~/Desktop/ngale/compiled-debug-x86_64
~/Desktop/ngale/compiled-debug-x86_64
allmakefiles.sh: done
configure: creating ./config.status
config.status: creating build/autodefs.mk
make -C /home/leonidas/Desktop/ngale/compiled-debug-`arch`
make[1]: Entering directory `/home/leonidas/Desktop/ngale/compiled-debug-x86_64'
/home/leonidas/Desktop/ngale/build/rules.mk:475: *** mixed implicit and normal rules.  Stop.
make[1]: Leaving directory `/home/leonidas/Desktop/ngale/compiled-debug-x86_64'
make: *** [build] Error 2

Edit: I was able to fix this issue by editing the problematic file.

Before:

Code:

dlldata.c %.h %.tlb %_i.c %_p.c: %.midl
    $(MIDL) $(MIDL_FLAGS) -Oicf $^

After:

Code:

#dlldata.c %.h %.tlb %_i.c %_p.c: %.midl
%.h %.tlb %_i.c %_p.c: %.midl
    $(MIDL) $(MIDL_FLAGS) -Oicf $^

dlldata.c: dlldata.midl
    $(MIDL) $(MIDL_FLAGS) -Oicf $^

This led to the next error:

Code:

g++ -o sbStringBundle.o -c -fPIC -fshort-wchar -fexceptions -fnon-call-exceptions -funwind-tables -fasynchronous-unwind-tables -fno-rtti -Wall -Wno-conversion -Wno-attributes -Wpointer-arith -Wcast-align -Wno-long-long -pipe -pthread -g -ggdb3 -fno-inline -include "mozilla-config.h" -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor  -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DDEBUG=1 -D_DEBUG=1 -DXP_UNIX=1 -D_REENTRANT=1  -I../../../../components/moz/strings/components/public -I/home/leonidas/Desktop/ngale/components/include -I/home/leonidas/Desktop/ngale/components/moz/strings/src -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/intl -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/uconv -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/nspr -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/xpcom -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/string  /home/leonidas/Desktop/ngale/components/moz/strings/src/sbStringBundle.cpp
/home/leonidas/Desktop/ngale/components/moz/strings/src/sbStringBundle.cpp: in method »nsString_external sbStringBundle::Format(const char*, const nsAString&, const char*)«:
/home/leonidas/Desktop/ngale/components/moz/strings/src/sbStringBundle.cpp:342:164: Error: cannot pass objects of non-trivially-copyable type »const class nsAString« through »...«
make[6]: *** [sbStringBundle.o] Error 1

I fixed this by changing the line to the corresponding line in the current svn version of songbird.

(~ components/moz/strings/src/sbStringBundle.cpp:342)
Before:

Code:

TRACE(("%s[%8.x] - %s (param %s) (default %s)",
         __FUNCTION__,
         this,
         aKey,
         aParam,
         aDefault));

After:

Code:

TRACE(("%s[%8.x] - %s (param %s) (default %s)",
         __FUNCTION__,
         this,
         aKey,
         NS_ConvertUTF16toUTF8(aParam).BeginReading(),
         aDefault));

It goes on...

Code:

g++ -o sbWindowWatcher.o -c -fPIC -fshort-wchar -fexceptions -fnon-call-exceptions -funwind-tables -fasynchronous-unwind-tables -fno-rtti -Wall -Wno-conversion -Wno-attributes -Wpointer-arith -Wcast-align -Wno-long-long -pipe -pthread -g -ggdb3 -fno-inline -include "mozilla-config.h" -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor  -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DDEBUG=1 -D_DEBUG=1 -DXP_UNIX=1 -D_REENTRANT=1  -I../../../../components/moz/windowwatcher/public -I../../../../components/moz/prompter/public -I/home/leonidas/Desktop/ngale/components/include -I/home/leonidas/Desktop/ngale/components/moz/threads/src -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/appshell -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/dom -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/necko -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/windowwatcher -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/nspr -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/xpcom -I/home/leonidas/Desktop/ngale/dependencies/linux-x86_64/mozilla/debug/include/string  /home/leonidas/Desktop/ngale/components/moz/windowwatcher/src/sbWindowWatcher.cpp
/home/leonidas/Desktop/ngale/components/moz/windowwatcher/src/sbWindowWatcher.cpp: In Elementfunktion »nsresult sbWindowWatcher::AddWindow(nsIDOMWindow*)«:
/home/leonidas/Desktop/ngale/components/moz/windowwatcher/src/sbWindowWatcher.cpp:659:100: Warnung: Vergleich zwischen vorzeichenbehafteten und vorzeichenlosen Ganzzahlausdrücken
/home/leonidas/Desktop/ngale/components/moz/windowwatcher/src/sbWindowWatcher.cpp: In Elementfunktion »virtual nsresult sbWindowWatcherEventListener::HandleEvent(nsIDOMEvent*)«:
/home/leonidas/Desktop/ngale/components/moz/windowwatcher/src/sbWindowWatcher.cpp:972:196: Fehler: cannot pass objects of non-trivially-copyable type »class nsCOMPtr<nsIDOMEventTarget>« through »...«
/home/leonidas/Desktop/ngale/components/moz/windowwatcher/src/sbWindowWatcher.cpp: In Elementfunktion »nsresult sbWindowWatcherEventListener::AddEventListener(const char*)«:
/home/leonidas/Desktop/ngale/components/moz/windowwatcher/src/sbWindowWatcher.cpp:1086:159: Fehler: cannot pass objects of non-trivially-copyable type »class nsCOMPtr<nsIDOMEventTarget>« through »...«
/home/leonidas/Desktop/ngale/components/moz/windowwatcher/src/sbWindowWatcher.cpp: In Elementfunktion »nsresult sbWindowWatcherEventListener::ClearEventListeners()«:
/home/leonidas/Desktop/ngale/components/moz/windowwatcher/src/sbWindowWatcher.cpp:1104:134: Fehler: cannot pass objects of non-trivially-copyable type »class nsCOMPtr<nsIDOMEventTarget>« through »...«
/home/leonidas/Desktop/ngale/components/moz/windowwatcher/src/sbWindowWatcher.cpp:1112:215: Fehler: cannot pass objects of non-trivially-copyable type »class nsCOMPtr<nsIDOMEventTarget>« through »...«
make[6]: *** [sbWindowWatcher.o] Fehler 1

Same Procedure, file components/moz/windowwatcher/src/sbWindowWatcher.cpp.
972:
Before:

Code:

TRACE(("%s: removed event %s listener %p from %p",
           __FUNCTION__,
           NS_ConvertUTF16toUTF8(eventType).get(),
           this,
          target));

After:

Code:

TRACE(("%s: removed event %s listener %p from %p",
           __FUNCTION__,
           NS_ConvertUTF16toUTF8(eventType).get(),
           this,
           target.get()));));

1086:
Before:

Code:

TRACE(("%s: Added event %s listener %p to %p",
         __FUNCTION__,
         aEventName,
         this,
         mEventTarget));

After:

Code:

TRACE(("%s: Added event %s listener %p to %p",
         __FUNCTION__,
         aEventName,
         this,
         mEventTarget.get()));

Similarly in lines 1104 and 1112. The "mEventTarget" has to be "mEventTarget.get()".

Building continues ...

Edit 2:
Ok there is more:

components/mediamanager/src/sbMediaFileManager.cpp:615
Before:

Code:

TRACE(("%s (%s)", __FUNCTION__, NS_ConvertUTF16toUTF8(aPropertyKey)));

After:

Code:

TRACE(("%s (%s)", __FUNCTION__, NS_ConvertUTF16toUTF8(aPropertyKey).BeginReading()));